PostEnglish
- 1 min read
- code-review
- process
- engineering-culture
Pull Requests and Why They're Not All That Bad
A point-by-point reply to Arkency's 'Disadvantages of pull requests' — most PR pain comes from how teams run reviews, not from the practice itself.
Recently, I stumbled upon an article on arkency — Disadvantages of pull requests. I soon realized this was interesting stuff, worth sharing with my colleagues. Immediately I started writing a follow-up article, debating every claim made in the text.
We practice PR review workflow in Productive’s engineering team daily. This workflow helps us with: ensuring code quality and stability, domain knowledge sharing in the team, organized mentoring activities.
The article answers the original claims one by one:
- long-living branches and merge conflicts,
- reviewability versus the size of a pull request,
- superficial reviews,
- blocking remarks that shouldn’t block,
- pull requests discouraging refactoring,
- negative emotions around reviews.
This is an excerpt — the full article was published on Medium.